Skip to content

This PR is to add comments to transformTolerations in pkg/ddc/alluxio/transform_resources.go.#4523

Merged
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
kennySDing:new-branch
Mar 13, 2025
Merged

This PR is to add comments to transformTolerations in pkg/ddc/alluxio/transform_resources.go.#4523
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
kennySDing:new-branch

Conversation

@kennySDing
Copy link
Copy Markdown
Contributor

@kennySDing kennySDing commented Mar 4, 2025

Ⅰ.Describe what this PR does
Add comments to transformTolerations in pkg/ddc/alluxio/transform_resources.go.
Ⅱ. Does this pull request fix one issue?
fixes #4522
Ⅲ. Special notes for reviews

// transformTolerations updates the Alluxio configuration with tolerations specified in the dataset.
// It iterates over each toleration in dataset.Spec.Tolerations, clears the TolerationSeconds field,
// and appends the modified toleration to value.Tolerations. This ensures that only the necessary toleration
// settings (without expiration) are transferred to the Alluxio value.

@kennySDing
Add Notation to transformTolerations in pkg/ddc/alluxio/transform_res…
356e459 
…ources.go.

Signed-off-by: kennySDing <1726669303@qq.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 4, 2025

Hi @kennySDing. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cheyang
cheyang requested changes Mar 5, 2025
View reviewed changes
Comment thread pkg/ddc/alluxio/transform_resources.go

}

// transformTolerations updates the Alluxio configuration with tolerations specified in the dataset.
Copy link
Copy Markdown
Collaborator

@cheyang cheyang Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert a blank line between the two functions. Thanks.

@cheyang
Gofmt pkg/ddc/alluxio/transform_resources.go
d6833b0 
Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang self-requested a review March 13, 2025 02:33
cheyang
cheyang approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Mar 13, 2025
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fluid-e2e-bot fluid-e2e-bot Bot merged commit 88f3434 into fluid-cloudnative:master Mar 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add comments to transformTolerations in pkg/ddc/alluxio/transform_resources.go.

2 participants

@kennySDing @cheyang